Skip to content

fix(CheckbxoList): resolve mvvm not work #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

fix(CheckbxoList): resolve mvvm not work #6060

merged 3 commits into from
May 20, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 20, 2025 •
edited by sourcery-ai bot
Loading

Link issues

fixes #6054

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Resolve MVVM binding issue in CheckboxListGeneric by simplifying state change logic and update relevant unit test to include ShowSwal flag

Bug Fixes:

  • Fix MVVM not working in CheckboxListGeneric by deriving CurrentValue from active items instead of manual list manipulation

Enhancements:

  • Replace manual building of selected values list with LINQ-based filtering of active items in CheckboxListGeneric

Tests:

  • Add ShowSwal property to SelectTest to properly simulate Swal display in unit tests

@bb-auto bb-auto bot added the bug Something isn't working label May 20, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 20, 2025 •
edited
Loading

Reviewer's Guide

Refactors the checkbox list component’s state update logic to derive values directly from the active items collection, ensuring MVVM bindings work correctly, and adds a missing ShowSwal flag in the select component unit test to complete test setup.

File-Level Changes

Change Details Files
Simplify state change handling in CheckboxListGeneric
  • Remove manual list construction and item lookup
  • Use Items.Where(i => i.Active).Select(i => i.Value).ToList() to build new value list
  • Assign filtered list directly to CurrentValue
 src/BootstrapBlazor/Components/Checkbox/CheckboxListGeneric.razor.cs
Add missing ShowSwal parameter in select component test
  • Include pb.Add(a => a.ShowSwal, true) in test setup
 test/UnitTest/Components/SelectTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6054 After the page is first shown, the selected state should match the bind-value, with all items checked initially. ✅
#6054 When an item is clicked, the bind-value should change as expected. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.6.0 milestone May 20, 2025
@ArgoZhang ArgoZhang merged commit 2518f86 into main May 20, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the fix-checkbox-list branch May 20, 2025 00:47
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (49b1c06) to head (801a5ad).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30956     30944   -12     
  Branches      4378      4376    -2     
=========================================
- Hits         30956     30944   -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sourcery-ai[bot]
sourcery-ai bot approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

v9.6.0

Development

Successfully merging this pull request may close these issues.

bug(CheckboxListGeneric): MVVM does not working expected

2 participants

@ArgoZhang